Fix bug #662 - cookies not being maintained correctly over session involving redirects+set-cookie - need to save cookie domain in sessions file - #1304
Closed
barny wants to merge 1 commit into
Closed
Conversation
barny
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
- Coverage 97.28% 96.52% -0.77%
==========================================
Files 67 85 +18
Lines 4235 6012 +1777
==========================================
+ Hits 4120 5803 +1683
- Misses 115 209 +94
Continue to review full report at Codecov.
|
barny
changed the title
barny
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed problems using --follow with --session, that on resuming using the saved session but expired authentication cookies stored in the session, httpie was generating duplicated cookies - saving the domain in the session file resolved this.